-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Replace difftest model with Quint=>MBT #1369
Conversation
…ck, not the new block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any glaring issues with the driver.
LGTM.
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
tests/mbt/driver/mbt_test.go
Outdated
// delivering the packet should give an error | ||
// if the consumer is timed out in the model | ||
var expectError bool | ||
if ConsumerStatus(currentModelState, consumerChain) == "timedout" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it'd be helpful to declare the consumer status as constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this big work @p-offtermatt. My review of the Quint code doesn't carry much weight as I'm not yet very familiar with the model yet. Apart from tiny nits, the driver code LGTM and is easier to read than the diff testing!
Description
Closes: #1241
Changes:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...